lkml.org 
[lkml]   [2015]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] Staging: vt6656: Checkpatch fix: else after break or return
On Tue, Jan 13, 2015 at 12:18:40PM +0530, Sudip Mukherjee wrote:
> On Tue, Jan 13, 2015 at 11:54:27AM +0530, Sudip Mukherjee wrote:
> > On Mon, Jan 12, 2015 at 09:58:17PM -0800, Greg KH wrote:
> > > On Tue, Jan 13, 2015 at 10:53:12AM +0530, Sudip Mukherjee wrote:
> > > >
> > > > any reason why this return was removed ?
> > >
> > > Because it's not needed.
> >
> > yes, it is not needed. but the way Emrys Bayliss has changed the code, then we will get a compiler warning about no return statement.
> i should have mentioned in my last mail that compiler will give waring if we compile with W=3
>

1) Your compiler is crap.
2) You should ignore obviously incorrect warnings.

I'm using GCC 4.7.2 and it doesn't give a warning for this. W=3 gives a
million other totally worthless warnings though. W=3 is not useful.

regards,
dan carpenter



\
 
 \ /
  Last update: 2015-01-13 12:21    [W:0.083 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site