Messages in this thread | | | Date | Mon, 12 Jan 2015 11:23:51 +0200 | From | Roger Quadros <> | Subject | Re: [PATCH v2 2/2] phy: ti-pipe3: Fix SATA across suspend/resume |
| |
On 09/01/15 15:59, Kishon Vijay Abraham I wrote: > Hi Roger, > > On Thursday 08 January 2015 04:47 PM, Roger Quadros wrote: >> Failed test case: Boot without SATA drive connected. Suspend/resume >> the board and then connect SATA drive. It fails to enumerate. >> >> Due to Errata i783 "SATA Lockup After SATA DPLL Unlock/Relock" >> we can't allow SATA DPLL to be in the unlocked state. >> The SATA refclk (sata_ref_clk) is the source of the SATA_DPLL. >> Till now this clock was controlled by the AHCI SATA driver and was being >> shut off during system suspend (if the SATA drive was not already attached) >> causing the SATA DPLL to be unlocked and so causing errata i783. >> >> To prevent sata_ref_clk from being disabled, we move the control of >> this clock from the SATA AHCI driver to the SATA PHY driver and prevent >> it from being disabled. >> >> This also fixes the issue of SATA not working on OMAP5/DRA7 when >> AHCI platform driver is built as a module. > > I feel the dt patches and the PHY patches can go separately. Can you split and > re-send?
OK. will re-send.
cheers, -roger
| |