Messages in this thread | | | From | Andy Lutomirski <> | Date | Mon, 12 Jan 2015 15:18:12 -0800 | Subject | Re: [PATCH 3.19 v2 1/3] x86: Fix off-by-one in the instruction decoder length checks |
| |
On Mon, Jan 12, 2015 at 3:13 PM, Dave Hansen <dave.hansen@linux.intel.com> wrote: > On 01/12/2015 03:04 PM, Andy Lutomirski wrote: >> diff --git a/arch/x86/lib/insn.c b/arch/x86/lib/insn.c >> index 2480978b31cc..1313ae6b478b 100644 >> --- a/arch/x86/lib/insn.c >> +++ b/arch/x86/lib/insn.c >> @@ -28,7 +28,7 @@ >> >> /* Verify next sizeof(t) bytes can be on the same instruction */ >> #define validate_next(t, insn, n) \ >> - ((insn)->next_byte + sizeof(t) + n < (insn)->end_kaddr) >> + ((insn)->next_byte + sizeof(t) + n <= (insn)->end_kaddr) >> >> #define __get_next(t, insn) \ >> ({ t r = *(t*)insn->next_byte; insn->next_byte += sizeof(t); r; }) > > This issue should already be handled by this patch: > > http://git.kernel.org/tip/0f363b250b15af0f218bb2876d101fe5cd413f8b
I wasn't paying much attention to the world for the last couple weeks, and I didn't notice that it was already fixed.
Ingo, etc: I won't send a v3 just to drop this patch from the series.
--Andy
-- Andy Lutomirski AMA Capital Management, LLC
| |