lkml.org 
[lkml]   [2015]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] x_tables: Factor out 16bit aligment ifname_compare()
Am 11.01.2015 um 21:59 schrieb Joe Perches:
> On Sun, 2015-01-11 at 21:52 +0100, Richard Weinberger wrote:
>> arp_tables.c has a 16bit aligment ifname_compare(), factor
>> it out to use it for all tables.
> []
>> diff --git a/include/linux/netfilter/x_tables.h b/include/linux/netfilter/x_tables.h
> []
>> @@ -331,14 +331,15 @@ static inline void xt_write_recseq_end(unsigned int addend)
>> /*
>> * This helper is performance critical and must be inlined
>> */
>> -static inline unsigned long ifname_compare_aligned(const char *_a,
>> - const char *_b,
>> - const char *_mask)
>> +static inline unsigned long ifname_compare(const char *_a,
>> + const char *_b,
>> + const char *_mask)
>
> Perhaps this would be better as bool ifname_compare

Let's discuss the whole concept first, then we can go to bikeshedding mode.

Thanks,
//richard


\
 
 \ /
  Last update: 2015-01-11 22:21    [W:1.014 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site