lkml.org 
[lkml]   [2015]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH v4 2/4] can: kvaser_usb: Update error counters before exiting on OOM
    From: Ahmed S. Darwish <ahmed.darwish@valeo.com>

    Let the error counters be more accurate in case of Out of
    Memory conditions.

    Suggested-by: Marc Kleine-Budde <mkl@pengutronix.de>
    Signed-off-by: Ahmed S. Darwish <ahmed.darwish@valeo.com>
    ---
    drivers/net/can/usb/kvaser_usb.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/net/can/usb/kvaser_usb.c b/drivers/net/can/usb/kvaser_usb.c
    index c32cd61..0eb870b 100644
    --- a/drivers/net/can/usb/kvaser_usb.c
    +++ b/drivers/net/can/usb/kvaser_usb.c
    @@ -792,6 +792,9 @@ static void kvaser_usb_rx_can_err(const struct kvaser_usb_net_priv *priv,
    }

    if (msg->u.rx_can.flag & MSG_FLAG_OVERRUN) {
    + stats->rx_over_errors++;
    + stats->rx_errors++;
    +
    skb = alloc_can_err_skb(priv->netdev, &cf);
    if (!skb) {
    stats->rx_dropped++;
    @@ -801,9 +804,6 @@ static void kvaser_usb_rx_can_err(const struct kvaser_usb_net_priv *priv,
    cf->can_id |= CAN_ERR_CRTL;
    cf->data[1] = CAN_ERR_CRTL_RX_OVERFLOW;

    - stats->rx_over_errors++;
    - stats->rx_errors++;
    -
    stats->rx_packets++;
    stats->rx_bytes += cf->can_dlc;
    netif_rx(skb);
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-01-11 21:41    [W:5.181 / U:0.904 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site