Messages in this thread | | | Subject | Re: [PATCH] staging: unisys: Convert direct LOGERR uses to pr_err | From | Joe Perches <> | Date | Sat, 10 Jan 2015 20:55:21 -0800 |
| |
On Sat, 2015-01-10 at 20:13 -0800, Greg Kroah-Hartman wrote: > On Sat, Jan 10, 2015 at 07:09:02PM -0800, Joe Perches wrote: > > Use the normal logging facility instead of a new macro. > > > > Miscellanea: > > > > o Realign arguments > > o Remove unnecessary alloc error messages as alloc failures > > already emits a generic OOM message with a dump_stack > > o Add missing newlines to these messages to avoid interleaving > > o Spelling/typo fixes in those messages [] > I rejected the other patch that did much this same thing, almost all of > these should be converted to use dev_* calls instead of pr_* calls, as > this is a driver, and drivers should always have access to a struct > device. If not, they need to be fixed.
Baby steps.
This one prevents interleaving and fixes typos.
| |