lkml.org 
[lkml]   [2014]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: randconfig build error with next-20140909, in drivers/net/ethernet/broadcom/cnic.c
From
Date
On Tue, 2014-09-09 at 23:16 +0000, Anish Bhatt wrote: 
> > It would be really good if SCSI_NETLINK depended on NET instead of selected NET.
> > We shouldn't have kconfig symbols that use 'select' on entire subsystems.
>
> As a test, I was able to fix this by this approach : change SCSI_NETLINK to depend
> on NET instead of selecting NET, and replacing 'select NETDEVICES ETHERNET
> NET_VENDOR_BROADCOM CNIC' to 'depends on CNIC' in bnx2i & bnx2fc. (as CNIC
> already has a dependency on those). This removes the need to check for IPV6 in
> bnx2i/fc Kconfigs as well.
>
> The side effect is that you won't see BNX2 drivers unless CNIC is selected, similar
> for SCSI_NETLINK as well, not sure if there are any other implications.

Right. I think it is more user-friendly for BNX2I and BNX2FC to select
CNIC. CNIC is not useful by itself and it makes more sense to select it
automatically when BNX2I/BNX2FC are enabled.




\
 
 \ /
  Last update: 2014-09-10 02:01    [W:0.033 / U:0.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site