lkml.org 
[lkml]   [2014]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC PATCH] pm: prevent suspend until power supply events are processed
From
On Wed, Sep 3, 2014 at 9:53 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 4 September 2014 10:21, Viresh Kumar <viresh.kumar@linaro.org> wrote:
>>>> >> + /* dependent power supplies (e.g. battery) may have changed
>>>> >> + * state as a result of this event, so poll again and hold
>>>> >> + * the wakeup_source until all events are processed.
>>>> >> + */
>
> But isn't this comment still incorrect? Its not about dependent supplies
> but the race between the work-handler and its enqueuing?

I believe you are correct: the code is to make sure we do not relax a
wakeup source that has had multiple events queued, until all are
notified to userspace.


Todd


\
 
 \ /
  Last update: 2014-09-10 00:21    [W:0.983 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site