lkml.org 
[lkml]   [2014]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/2] xtensa/uapi: Add definition of TIOC[SG]RS485
Done

Thanks :)

On Tue, Sep 9, 2014 at 9:18 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Tue, Sep 09, 2014 at 07:20:56AM +0200, Ricardo Ribalda Delgado wrote:
>> Commit: e676253b19b2d269cccf67fdb1592120a0cd0676 [3/21] serial/8250: Add
>> support for RS485 IOCTLs, adds support for RS485 ioctls for 825_core on
>> all the archs. Unfortunaltely the definition of TIOCSRS485 and
>> TIOCGRS485 was missing on the ioctls.h file
>>
>> Reported-by: kbuild test robot <fengguang.wu@intel.com>
>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
>> ---
>> arch/xtensa/include/uapi/asm/ioctls.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/xtensa/include/uapi/asm/ioctls.h b/arch/xtensa/include/uapi/asm/ioctls.h
>> index a47909f..accda82 100644
>> --- a/arch/xtensa/include/uapi/asm/ioctls.h
>> +++ b/arch/xtensa/include/uapi/asm/ioctls.h
>> @@ -95,6 +95,8 @@
>> #define TCSETS2 _IOW('T', 43, struct termios2)
>> #define TCSETSW2 _IOW('T', 44, struct termios2)
>> #define TCSETSF2 _IOW('T', 45, struct termios2)
>> +#define TIOCGRS485 0x542E
>> +#define TIOCSRS485 0x542F
>
> Like your patches for other arches, please use a _IOW() macro here, not a "number".
>
> thanks,
>
> greg k-h



--
Ricardo Ribalda


\
 
 \ /
  Last update: 2014-09-09 22:21    [W:1.033 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site