Messages in this thread Patch in this message | | | Date | Tue, 9 Sep 2014 07:53:08 -0700 | From | tip-bot for Andreea-Cristina Bernat <> | Subject | [tip:perf/core] perf/core: Replace rcu_assign_pointer() with RCU_INIT_POINTER() |
| |
Commit-ID: 70691d4a0bf7c871559d4ef1b0056edefbca123b Gitweb: http://git.kernel.org/tip/70691d4a0bf7c871559d4ef1b0056edefbca123b Author: Andreea-Cristina Bernat <bernat.ada@gmail.com> AuthorDate: Fri, 22 Aug 2014 16:26:05 +0300 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Tue, 9 Sep 2014 06:53:05 +0200
perf/core: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
The use of "rcu_assign_pointer()" is NULLing out the pointer. According to RCU_INIT_POINTER()'s block comment:
"1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead.
The following Coccinelle semantic patch was used: @@ @@
- rcu_assign_pointer + RCU_INIT_POINTER (..., NULL)
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Cc: Arnaldo Carvalho de Melo <acme@kernel.org> Link: http://lkml.kernel.org/r/20140822132605.GA20130@ada Signed-off-by: Ingo Molnar <mingo@kernel.org> --- kernel/events/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c index 01bd42e..f917dec 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -5908,7 +5908,7 @@ static void swevent_hlist_release(struct swevent_htable *swhash) if (!hlist) return; - rcu_assign_pointer(swhash->swevent_hlist, NULL); + RCU_INIT_POINTER(swhash->swevent_hlist, NULL); kfree_rcu(hlist, rcu_head); }
| |