lkml.org 
[lkml]   [2014]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH v3] rtc: ds1307: add trickle charger device tree binding
On Tue, Sep 09, 2014 at 11:29:11AM +0300, Matti Vaittinen wrote:
> On Mon, Sep 08, 2014 at 07:26:57AM -0400, ext Jason Cooper wrote:
> > Matti,
> >
> > On Mon, Sep 08, 2014 at 10:32:24AM +0300, Matti Vaittinen wrote:
> > > ---
> >
> > Here. Otherwise, it'll get included in the commit message, which I
> > don't think was your intention.
>
> Ok, thanks.
>
> >
> > > .../devicetree/bindings/i2c/trivial-devices.txt | 1 -
> > > .../devicetree/bindings/rtc/dallas,ds1339.txt | 18 ++++++
> > > drivers/rtc/rtc-ds1307.c | 66 ++++++++++++++++++++--
> > > 3 files changed, 80 insertions(+), 5 deletions(-)
> > > create mode 100644 Documentation/devicetree/bindings/rtc/dallas,ds1339.txt
> >
> > I would split this into two patches, one for the binding documentation,
> > and one for the C file changes. You can then use
> > ./scripts/get_maintainer.pl to see who the rtc maintainer is (nothing
> > jumps out from my memory).
>
> Splitting sounds reasonable. I will do this and also invert the default
> diode setting to be connected as was suggested by Pavel in mail responce
> to v1 of patch. And Alessandro is the maintainer for rtc according to
> the MAINTAINERS file.
>
> >
> > Most likely, the rtc maintainer will take the series with the DT
> > maintainers Acks. You made all the binding changes as discussed by Mark
> > and I, so fwiw,
> >
> > Acked-by: Jason Cooper <jason@lakedaemon.net>
> >
> > Just keep in mind that I'm not a DT maintainer, I've just moved a lot of
> > patches into that area :-P When you respin the series to split it, just
> > throw my Ack on the binding docs.
>
> Thanks, although the doc will change when I invert the default diode
> setting =)

Yep, I'm fine with the inversion. Feel free to keep the Ack.

thx,

Jason.


\
 
 \ /
  Last update: 2014-09-09 14:01    [W:0.128 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site