Messages in this thread | | | Date | Tue, 9 Sep 2014 07:19:50 +0530 | Subject | Re: [PATCH v6 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800 | From | Vivek Gautam <> |
| |
Hi,
On Mon, Sep 8, 2014 at 7:14 PM, Felipe Balbi <balbi@ti.com> wrote: > Hi, > > On Mon, Sep 08, 2014 at 09:53:09AM +0530, Vivek Gautam wrote: >> On Fri, Sep 5, 2014 at 11:26 PM, Felipe Balbi <balbi@ti.com> wrote: >> > On Thu, Sep 04, 2014 at 12:01:19PM +0530, Vivek Gautam wrote: >> >> > Don't we have phy_power_on() >> >> > for that ? It looks like you could just as well do this from >> >> > phy_power_on() ? >> >> >> >> No, unfortunately keeping these calibration settings in phy_power_on() >> >> doesn't help, since we need to do this after XHCI reset has happened. >> > >> > teach xHCI about PHYs ? >> >> sorry i couldn't understand you here. >> Aren't we trying to do the same with Heikki's patch about dwc3 : >> [PATCH 6/6] usb: dwc3: host: convey the PHYs to xhci >> >> and the 2nd patch in this series : >> [PATCH v6 2/4] usb: host: xhci-plat: Get PHYs for xhci's hcds >> >> Is there something else that is expected ? > > right, use that to call phy_init() at the right time, then you need to > add a new ->calibrate() method which, likely, will only be used by you > ;-)
so you mean, the xhci should itself call phy_init() at a time suitable, so that ->calibrate() is not required at all ?
i think you meant there - "then you __do not__ need to > add a new ->calibrate() method which, likely, will only be used by you", is it ?
-- Best Regards Vivek Gautam Samsung R&D Institute, Bangalore India
| |