Messages in this thread | | | Date | Sun, 7 Sep 2014 08:46:25 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH] ext4: Fixed styling issues |
| |
On Sun, Sep 07, 2014 at 03:16:22PM +0200, Richard Weinberger wrote: > On Sun, Sep 7, 2014 at 2:45 PM, Daniel Bomar <dbdaniel42@gmail.com> wrote: > > Fixed styling issues as reported by scripts/checkpatch.pl > > > > Signed-off-by: Daniel Bomar <dbdaniel42@gmail.com> > > Please don't run checkpatch.pl on in-kernel files.
I don't think it's up to us to tell people what files they should run patches on on.. That doesn't mean that pure style cleanup patches in an area you don't understand are a good idea, so don't send them. This is different when you actually do a major overhaul of an area, in which case I'd actually like to do a first pass of style cleanup and refactoring before submitting the real work.
| |