Messages in this thread | | | Date | Sat, 6 Sep 2014 03:00:40 +0900 | From | Tejun Heo <> | Subject | Re: [Patch v4 1/2] freezer: check OOM kill while being frozen |
| |
On Fri, Sep 05, 2014 at 09:31:50AM -0700, Cong Wang wrote: > On Fri, Sep 5, 2014 at 7:08 AM, Tejun Heo <tj@kernel.org> wrote: > >> + /* It might not be safe to check TIF_MEMDIE for pm freeze. */ > > > > This is just another representation of the following code which isn't > > particularly useful. Wouldn't it be better if the comment actually > > explains why this might not be safe? > > I don't know actually, I never understand pm code, just don't > want to take the risk of breaking it as you told. :)
Let's please try to understand and explain it properly. Reading intricate code like this w/ comment which doesn't really explain anything can be very frustrating for other people reading the code. Rafael, can you please help?
Shouldn't the primary goal of the comment be explaining why we need TIF_MEMDIE check there at all anyway? The deadlock possiblity is not very obvious.
Thanks.
-- tejun
| |