Messages in this thread | | | Date | Thu, 4 Sep 2014 09:37:39 +0100 | From | Ian Abbott <> | Subject | Re: [PATCH] staging: comedi: hwdrv_apci1500: use dev->class_dev in calls to dev_warn() |
| |
On 2014-09-04 00:58, Chase Southwood wrote: > git-grep reveals that hwdrv_apci1500.c is the only file in comedi that uses > dev->hw_dev in calls to dev_{err,warn}(). The rest of the drivers pass > dev->class_dev to these macros instead. Switch the dev_warn() calls in > this driver to use dev->class_dev as well, for consistency. > > Signed-off-by: Chase Southwood <chase.southwood@gmail.com> > Cc: Ian Abbott <abbotti@mev.co.uk> > Cc: H Hartley Sweeten <hsweeten@visionengravers.com> > --- > As an aside, it looks like lots of these cases are actually error > conditions that might be more appropriate use cases for dev_err(). But > they could be changed in a follow on patch, this is enough for this one. > .../comedi/drivers/addi-data/hwdrv_apci1500.c | 104 ++++++++++----------- > 1 file changed, 52 insertions(+), 52 deletions(-)
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
| |