Messages in this thread | | | Date | Thu, 4 Sep 2014 10:15:22 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH resend 2/2] usb: serial: xsens_mt: always bind to interface number 1 |
| |
On Thu, Sep 04, 2014 at 09:12:05AM +0200, Frans Klaver wrote:
> > static int xsens_mt_probe(struct usb_serial *serial, > > const struct usb_device_id *id) > > { > > - if (!has_required_endpoints(serial->interface->cur_altsetting)) > > - return -ENODEV; > > - return 0; > > + if (serial->interface->cur_altsetting.desc.bInterfaceNumber == 1) > > This should be > > if (serial->interface->cur_altsetting->desc.bInterfaceNumber == 1)
So this wasn't even compile tested. Always test your patches before submission, including trivial ones.
Is the new version tested on actual hardware?
Johan
| |