| Date | Thu, 4 Sep 2014 13:14:24 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 05/17] locks: generic_delete_lease doesn't need a file_lock at all |
| |
On Thu, Sep 04, 2014 at 08:38:31AM -0400, Jeff Layton wrote: > Ensure that it's OK to pass in a NULL file_lock double pointer on > a F_UNLCK request and convert the vfs_setlease F_UNLCK callers to > do just that. > > Finally, turn the BUG_ON in generic_setlease into a WARN_ON_ONCE > with an error return. That's a problem we can handle without > crashing the box if it occurs.
Can we just make generic_delete_lease (maye renamed to vfs_delete_lease) the interface for deleting leases instead of going through a useless multiplex and file operation?
|