lkml.org 
[lkml]   [2014]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] [media] dib0090: remove manual configuration system
From
Date
Hi Mauro,

On Thu, 2014-09-04 at 12:36 -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 22 May 2014 14:48:07 +0200
> Paul Bolle <pebolle@tiscali.nl> escreveu:
>
> > dib0900.c has always shipped with its own, manual, configuration
> > system. There a three problems with it.
> >
> > 1) macros that are defined, but not used:
> > CONFIG_SYS_DVBT
> > CONFIG_DIB0090_USE_PWM_AGC
> >
> > 2) checks for macros that are always true:
> > CONFIG_SYS_ISDBT
> > CONFIG_BAND_CBAND
> > CONFIG_BAND_VHF
> > CONFIG_BAND_UHF
> >
> > 3) checks for macros that are never defined and are always false:
> > CONFIG_BAND_SBAND
> > CONFIG_STANDARD_DAB
> > CONFIG_STANDARD_DVBT
> > CONFIG_TUNER_DIB0090_P1B_SUPPORT
> > CONFIG_BAND_LBAND
> >
> > Remove all references to these macros, and, of course, remove the code
> > hidden behind the macros that are never defined too.
>
> IMHO, it is OK to remove the macros that are always true and
> the ones that aren't used.

I see. I hope to send a v2 that does that one of these days.

> However, I don't like the idea of
> removing the other macros. This is a tuner driver that can be used
> on other bands, and some day we might end implementing analog support
> for the Dibcom driver or to add something that will require the code
> there. So, IMHO, better to keep the code there.

But would you consider a patch that at least moves those macros out of
the CONFIG_* namespace (ie, a patch that prefixes those macros with,
say, DIB0090_)?


Paul Bolle



\
 
 \ /
  Last update: 2014-09-04 22:21    [W:3.508 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site