Messages in this thread | | | Date | Tue, 30 Sep 2014 17:59:05 -0700 | From | Sukadev Bhattiprolu <> | Subject | Re: [v2,2/4] Simplify catalog_read() |
| |
Michael Ellerman [mpe@ellerman.id.au] wrote: | > @@ -203,6 +125,7 @@ static ssize_t catalog_read(struct file *filp, struct kobject *kobj, | > | > page_offset = offset / 4096; | > page_count = count / 4096; | | I don't see where page_count is used.
Yes, I will remove it.
| | > + offset_in_page = count % 4096; | | Shouldn't offset_in_page be based on offset ?
Yes. I will fix that.
Thanks,
Sukadev
| |