lkml.org 
[lkml]   [2014]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [v2,2/4] Simplify catalog_read()
Michael Ellerman [mpe@ellerman.id.au] wrote:
| > @@ -203,6 +125,7 @@ static ssize_t catalog_read(struct file *filp, struct kobject *kobj,
| >
| > page_offset = offset / 4096;
| > page_count = count / 4096;
|
| I don't see where page_count is used.

Yes, I will remove it.

|
| > + offset_in_page = count % 4096;
|
| Shouldn't offset_in_page be based on offset ?

Yes. I will fix that.

Thanks,

Sukadev



\
 
 \ /
  Last update: 2014-10-01 03:41    [W:0.059 / U:0.876 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site