lkml.org 
[lkml]   [2014]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regmap: Allow read_reg_mask to be 0
On Tue, Sep 30, 2014 at 11:07:00AM -0500, Dan Murphy wrote:

> - if (config->read_flag_mask || config->write_flag_mask) {
> + if (config->read_flag_mask == REGMAP_NO_READ_MASK)
> + map->read_flag_mask = 0x00;
> + else if (config->read_flag_mask)

This breaks the symmetry in handling of read and write masks which isn't
great, please make the equivalent update for the write mask too.

> +#define REGMAP_NO_READ_MASK 0xff

An actual out of band value might be preferable here though that'd
involve changing the type and more checking so perhaps inessential.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-09-30 19:41    [W:0.100 / U:1.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site