Messages in this thread | | | From | Chao Yu <> | Subject | RE: [f2fs-dev] [PATCH 2/3] f2fs: introduce FITRIM in f2fs_ioctl | Date | Tue, 30 Sep 2014 14:01:58 +0800 |
| |
> -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Tuesday, September 23, 2014 12:53 PM > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 2/3] f2fs: introduce FITRIM in f2fs_ioctl > > This patch introduces FITRIM in f2fs_ioctl. > In this case, f2fs will issue small discards and prefree discards as many as > possible for the given area. > > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Looks good!
Reviewed-by: Chao Yu <chao2.yu@samsung.com>
> + > /* zero block will be discarded through the prefree list */ > if (!se->valid_blocks || se->valid_blocks == max_blocks) > return; > > + dmap = kzalloc(SIT_VBLOCK_MAP_SIZE, GFP_KERNEL);
We can afford 64 bytes allocation in stack, how about altering dmap to a local array to reduce memory pressure at that moment and avoid delay of allocation?
> + if (!dmap) > + return; > +
| |