lkml.org 
[lkml]   [2014]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sched: fix spurious active migration
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/30/2014 04:41 AM, Vincent Guittot wrote:
> Since commit caeb178c60f4 ("sched/fair: Make
> update_sd_pick_busiest() ...") sd_pick_busiest returns a group that
> can be neither imbalanced nor overloaded but is only more loaded
> than others. This change has been introduced to ensure a better
> load balance in system that are not overloaded but as a side
> effect, it can also generate useless active migration between
> groups.
>
> Let take the example of 3 tasks on a quad cores system. We will
> always have an idle core so the load balance will find a busiest
> group (core) whenever an ILB is triggered and it will force an
> active migration (once above nr_balance_failed threshold) so the
> idle core becomes busy but another core will become idle. With the
> next ILB, the freshly idle core will try to pull the task of a busy
> CPU. The number of spurious active migration is not so huge in quad
> core system because the ILB is not triggered so much. But it
> becomes significant as soon as you have more than one sched_domain
> level like on a dual cluster of quad cores where the ILB is
> triggered every tick when you have more than 1 busy_cpu
>
> We need to ensure that the migration generate a real improveùent
> and will not only move the avg_load imbalance on another CPU.

Good catch.

> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>

Reviewed-by: Rik van Riel <riel@redhat.com>


- --
All rights reversed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUKoD0AAoJEM553pKExN6DD4UIAIDM2q15MMhgKOEhKzFJfBod
XXeP5ouzeyRYwBomZhQazBqX42YOQ9YsYwydYJNacUcCP41DTNElvwOY6/l6znHK
GqYQFPxEtoi1e42EHvqQUVeISjKk1RFWpf4kQI8qhq1lYClWakn6ATk5RzbImYTR
MxjDL3WOXkywo9+lksF+N4TjpuBRDA5YKGvjSozeGMJFZyMzBsBNQDfDbv6ccHx3
uTPVi+3UXbVuTVsa5imHayxFL1+aEBMhBd2Y3mdQdKwds3SCHxrU+3v3o4wAm8qI
AD6l/QTmPnwUKCeZod9fXZLApFFIO5aQgQBCEj3M2Sz9HtsbQjJoxL3gybbUBug=
=ja1y
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-09-30 12:41    [W:0.204 / U:0.964 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site