lkml.org 
[lkml]   [2014]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] ARM: DT: apq8064: add rpm support


On 30/09/14 06:11, Bjorn Andersson wrote:

>>
>> + apcs: syscon@2011000 {
>> + compatible = "syscon";
>> + reg = <0x2011000 0x1000>;
>> + };
>> +
>> + rpm@108000 {
>> + compatible = "qcom,rpm-apq8064";
>> + reg = <0x108000 0x1000>;
>> + qcom,ipc = <&apcs 0x8 2>;
>
> I don't like your indentation, but please stick with one way of doing it :)
>
I agree, Will fix this in next version.
>> +
>> + interrupts = <0 19 0>, <0 21 0>, <0 22 0>;
>> + interrupt-names = "ack", "err", "wakeup";
>> +
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>
> This part looks good.
>
> But how about adding all the regulators here as well?
Yes we can add for the sake of completeness but w.r.t testing only some
of them will be tested
> Like:
>
> pm8921_l5: pm8921-l5 {
> compatible = "qcom,rpm-pm8921-pldo";
> reg = <QCOM_RPM_PM8921_LDO5>;
> };
>
Adding nodes like this should be trival.
> ...
>
> That way we can update the references from this file (while still allowing the
> dts to override it if needed). I'm not sure if we should add some sane defaults
> or just completely deferr specifying the voltage ranges to the dts. The benefit
> of the latter is that the regulators not configured by the dts author will not
> be accessible.
>
> But simply listing all the nodes here would be nice and I dont see much reason
> to postpone this work.
Ok.. will be done in next version.


--srini
>
>> + };
>> +
>> /* Temporary fixed regulator */
>> vsdcc_fixed: vsdcc-regulator {
>> compatible = "regulator-fixed";
>
> Regards,
> Bjorn
>


\
 
 \ /
  Last update: 2014-09-30 10:01    [W:0.262 / U:1.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site