Messages in this thread | | | Subject | Re: Bogus error in checkpatch.pl | From | Joe Perches <> | Date | Tue, 02 Sep 2014 22:34:30 -0700 |
| |
On Wed, 2014-09-03 at 00:29 -0400, Pranith Kumar wrote: > Hi Joe,
Hello Pranith.
> On Wed, Sep 3, 2014 at 12:25 AM, Joe Perches <joe@perches.com> wrote: > > You need to use parentheses around the description like: > > commit <commitid> ("commit description") > > For your case: > > Commit 615cc2c9cf95 ("Documentation/memory-barriers.txt: fix important > > typo re memory barriers") > Ah, OK. But the error message does not say anything about missing > paranetheses and only stresses on chars in the id: > > $ ./scripts/checkpatch.pl > patch_dir/0001-doc-memory-barriers.txt-Correct-example-for-reorderi.patch > ERROR: Please use 12 or more chars for the git commit ID like: 'Commit > 615cc2c9cf95 ("Documentation/memory-barriers.txt: fix important typo > re memory barriers")' > #8: > Commit 615cc2c9cf95 "Documentation/memory-barriers.txt: fix important typo re > Is it possible to make it a bit clearer, perhaps?
Maybe. Suggest a modified message.
| |