Messages in this thread | | | Date | Mon, 29 Sep 2014 08:59:59 +0200 | Subject | Re: [PATCH] perf tools: fix build breakage on arm and arm64 targets | From | Jean Pihet <> |
| |
Hi Will,
On 26 September 2014 19:19, Sudeep Holla <sudeep.holla@arm.com> wrote: > > On 26/09/14 18:01, Will Deacon wrote: >> >> Attempting to build the perf tool on arm or arm64 targets results in the >> following failure: >> >> arch/arm/util/unwind-libunwind.c: In function ‘libunwind__arch_reg_id’: >> arch/arm/util/unwind-libunwind.c:43:3: error: implicit declaration of >> function ‘pr_err’ [-Werror=implicit-function-declaration] >> pr_err("unwind: invalid reg id %d\n", regnum); >> ^ >> This is due to commit 84f5d36f4866 ("perf tools: Move pr_* debug macros >> into debug object") moving the pr_* macros into a new header file, but >> failing to update architectures other than x86. >> >> This patch adds the missing includes, and fixes the build again.
The fix for ARM is already in the tip tree at http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=29a3ce31c38c8f73f4e076b7ffc0876b4f5dd6c3.
Regards, Jean
>> > > For ARM64, we also need the patch[1] "perf tools: Fix arm64 build error" > which is already queued in linux-next. > > Regards, > Sudeep > > [1] https://lkml.org/lkml/2014/6/24/1024 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |