Messages in this thread | | | Date | Mon, 29 Sep 2014 01:53:08 +0100 (BST) | From | "Maciej W. Rozycki" <> | Subject | Re: [PATCH] MIPS: R3000: Fix debug output for Virtual page number |
| |
On Wed, 10 Sep 2014, Isamu Mogi wrote:
> Virtual page number of R3000 in entryhi is 20 bit from MSB. But in > dump_tlb(), the bit mask to read it from entryhi is 19 bit (0xffffe000). > The patch fixes that to 0xfffff000. > > Signed-off-by: Isamu Mogi <isamu@leafytree.jp>
Acked-by: Maciej W. Rozycki <macro@linux-mips.org>
It would be good to add appropriate macros to <asm/mipsregs.h> too, to avoid magic numbers and decrease the likelihood of issues like this. As a separate change, that is, of course, and not a prerequisite.
Maciej
| |