lkml.org 
[lkml]   [2014]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2 linux-next] jffs2: fix sparse warning: unexpected unlock
On Sun, Sep 28, 2014 at 09:26:32PM +0200, Fabian Frederick wrote:
> fs/jffs2/summary.c:846:5: warning: context imbalance in 'jffs2_sum_write_sumnode' - unexpected unlock
>
> Suggested-by: Brian Norris <computersforpeace@gmail.com>
> Suggested-by: Josh Triplett <josh@joshtriplett.org>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> V2: use __must_hold instead of __releases / __acquires
> (suggested by Brian Norris and Josh Triplett)
>
> fs/jffs2/summary.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/jffs2/summary.c b/fs/jffs2/summary.c
> index c522d09..bc53854 100644
> --- a/fs/jffs2/summary.c
> +++ b/fs/jffs2/summary.c
> @@ -844,6 +844,7 @@ static int jffs2_sum_write_data(struct jffs2_sb_info *c, struct jffs2_eraseblock
> /* Write out summary information - called from jffs2_do_reserve_space */
>
> int jffs2_sum_write_sumnode(struct jffs2_sb_info *c)
> + __must_hold(&c->erase_completion_block)
> {
> int datasize, infosize, padsize;
> struct jffs2_eraseblock *jeb;
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html


\
 
 \ /
  Last update: 2014-09-29 02:41    [W:0.297 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site