Messages in this thread | | | Date | Sat, 27 Sep 2014 12:18:36 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v5 1/2] regulator: st-pwm: get voltage and duty table from dts |
| |
On Tue, Sep 23, 2014 at 09:42:58PM +0800, Chris Zhong wrote:
> Get voltage & duty table from device tree might be better, other platforms can also use this > driver without any modify.
Please wrap your changelogs to less than 80 characters.
> diff --git a/drivers/regulator/pwm-regulator.c b/drivers/regulator/pwm-regulator.c > new file mode 100644 > index 0000000..d3f55ea > --- /dev/null > +++ b/drivers/regulator/pwm-regulator.c > @@ -0,0 +1,197 @@ > +/* > + * Regulator driver for PWM Regulators > + * > + * Copyright (C) 2014 - STMicroelectronics Inc. > + * > + * Author: Lee Jones <lee.jones@linaro.org> > + *
Generate patches renaming files with git format-patch -M - as things stand since this deletes and re-adds the code it's very difficult to review, it's equivalent to just re-reviewing the driver from scratch. [unhandled content-type:application/pgp-signature] | |