lkml.org 
[lkml]   [2014]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 060/142] Drivers: scsi: storvsc: Change the limits to reflect the values on the host
    Date
    From: "K. Y. Srinivasan" <kys@microsoft.com>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit 4cd83ecdac20d30725b4f96e5d7814a1e290bc7e upstream.

    Hyper-V hosts can support multiple targets and multiple channels and larger number of
    LUNs per target. Update the code to reflect this. With this patch we can correctly
    enumerate all the paths in a multi-path storage environment.

    Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
    Reviewed-by: Hannes Reinecke <hare@suse.de>
    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    drivers/scsi/storvsc_drv.c | 47 ++++++++++++++++++++++++++++++----------------
    1 file changed, 31 insertions(+), 16 deletions(-)

    diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
    index 4bae90722ad2..8292628c109c 100644
    --- a/drivers/scsi/storvsc_drv.c
    +++ b/drivers/scsi/storvsc_drv.c
    @@ -331,17 +331,17 @@ static int storvsc_timeout = 180;

    static void storvsc_on_channel_callback(void *context);

    -/*
    - * In Hyper-V, each port/path/target maps to 1 scsi host adapter. In
    - * reality, the path/target is not used (ie always set to 0) so our
    - * scsi host adapter essentially has 1 bus with 1 target that contains
    - * up to 256 luns.
    - */
    -#define STORVSC_MAX_LUNS_PER_TARGET 64
    -#define STORVSC_MAX_TARGETS 1
    -#define STORVSC_MAX_CHANNELS 1
    +#define STORVSC_MAX_LUNS_PER_TARGET 255
    +#define STORVSC_MAX_TARGETS 2
    +#define STORVSC_MAX_CHANNELS 8

    +#define STORVSC_FC_MAX_LUNS_PER_TARGET 255
    +#define STORVSC_FC_MAX_TARGETS 128
    +#define STORVSC_FC_MAX_CHANNELS 8

    +#define STORVSC_IDE_MAX_LUNS_PER_TARGET 64
    +#define STORVSC_IDE_MAX_TARGETS 1
    +#define STORVSC_IDE_MAX_CHANNELS 1

    struct storvsc_cmd_request {
    struct list_head entry;
    @@ -1713,7 +1713,6 @@ static struct scsi_host_template scsi_driver = {
    .slave_destroy = storvsc_device_destroy,
    .slave_configure = storvsc_device_configure,
    .cmd_per_lun = 1,
    - /* 64 max_queue * 1 target */
    .can_queue = STORVSC_MAX_IO_REQUESTS*STORVSC_MAX_TARGETS,
    .this_id = -1,
    /* no use setting to 0 since ll_blk_rw reset it to 1 */
    @@ -1778,6 +1777,9 @@ static int storvsc_probe(struct hv_device *device,
    }


    + if (dev_id->driver_data == SFC_GUID)
    + scsi_driver.can_queue = (STORVSC_MAX_IO_REQUESTS *
    + STORVSC_FC_MAX_TARGETS);
    host = scsi_host_alloc(&scsi_driver,
    sizeof(struct hv_host_device));
    if (!host)
    @@ -1811,12 +1813,25 @@ static int storvsc_probe(struct hv_device *device,
    host_dev->path = stor_device->path_id;
    host_dev->target = stor_device->target_id;

    - /* max # of devices per target */
    - host->max_lun = STORVSC_MAX_LUNS_PER_TARGET;
    - /* max # of targets per channel */
    - host->max_id = STORVSC_MAX_TARGETS;
    - /* max # of channels */
    - host->max_channel = STORVSC_MAX_CHANNELS - 1;
    + switch (dev_id->driver_data) {
    + case SFC_GUID:
    + host->max_lun = STORVSC_FC_MAX_LUNS_PER_TARGET;
    + host->max_id = STORVSC_FC_MAX_TARGETS;
    + host->max_channel = STORVSC_FC_MAX_CHANNELS - 1;
    + break;
    +
    + case SCSI_GUID:
    + host->max_lun = STORVSC_MAX_LUNS_PER_TARGET;
    + host->max_id = STORVSC_MAX_TARGETS;
    + host->max_channel = STORVSC_MAX_CHANNELS - 1;
    + break;
    +
    + default:
    + host->max_lun = STORVSC_IDE_MAX_LUNS_PER_TARGET;
    + host->max_id = STORVSC_IDE_MAX_TARGETS;
    + host->max_channel = STORVSC_IDE_MAX_CHANNELS - 1;
    + break;
    + }
    /* max cmd length */
    host->max_cmd_len = STORVSC_MAX_CMD_LEN;

    --
    2.1.0


    \
     
     \ /
      Last update: 2014-09-26 13:01    [W:3.713 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site