Messages in this thread | | | Date | Thu, 25 Sep 2014 22:11:30 -0700 | Subject | Re: [PATCH v14 net-next 10/11] bpf: verifier (add verifier core) | From | Alexei Starovoitov <> |
| |
On Thu, Sep 25, 2014 at 9:40 PM, David Miller <davem@davemloft.net> wrote: > From: Alexei Starovoitov <ast@plumgrid.com> > Date: Sun, 21 Sep 2014 17:06:50 -0700 > >> +#define _(OP) ({ int ret = (OP); if (ret < 0) return ret; }) > > Please do not hide program control flow inside of a macro.
ok. I'm pretty sure it will be less readable, but I'll get rid off it. I'm assuming you considered my arguments about it here: https://lkml.org/lkml/2014/7/2/656 No problem. It's a minor thing.
| |