Messages in this thread | | | Date | Thu, 25 Sep 2014 21:54:54 +0200 | From | Antoine Tenart <> | Subject | Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx |
| |
Arnd,
On Thu, Sep 25, 2014 at 09:12:07PM +0200, Arnd Bergmann wrote: > On Tuesday 23 September 2014, Antoine Tenart wrote: > > +static int ci_hdrc_usb2_dt_probe(struct device *dev, > > + struct ci_hdrc_platform_data *ci_pdata) > > +{ > > + ci_pdata->phy = of_phy_get(dev->of_node, 0); > > FWIW, I accidentally built a kernel with this driver enabled and got a warning > for this code. The problem is that ci_pdata->phy is a 'struct usb_phy' pointer, > while of_phy_get() returns a generic 'struct phy'. While the two have similar > behavior, they are not the same thing and this can't work.
That's because this series applies on top of: https://lkml.org/lkml/2014/9/15/141
Antoine
-- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |