Messages in this thread | | | Date | Thu, 25 Sep 2014 17:03:53 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v6 3/4] usb: Rename usb-common.c |
| |
On Wed, Sep 24, 2014 at 10:43:20PM +0200, Michal Sojka wrote: > In the next commit, we will want the usb-common module to be composed of > two object files. Since Kbuild cannot "append" another object to an > existing one, we need to rename usb-common.c to something > else (common.c) and create usb-common.o by linking the wanted objects > together. Currently, usb-common.o comprises only common.o. > > Signed-off-by: Michal Sojka <sojka@merica.cz> > Acked-by: Felipe Balbi <balbi@ti.com> > Tested-by: Felipe Balbi <balbi@ti.com> > --- > drivers/usb/common/Makefile | 4 +- > drivers/usb/common/common.c | 144 ++++++++++++++++++++++++++++++++++++++++ > drivers/usb/common/usb-common.c | 144 ---------------------------------------- > 3 files changed, 147 insertions(+), 145 deletions(-) > create mode 100644 drivers/usb/common/common.c > delete mode 100644 drivers/usb/common/usb-common.c
In the future, please generate a git "move" diff, which makes it easier to review, and prove that nothing really changed. It also helps if the file is a bit different from what you diffed against, which in my case, was true.
thanks,
greg k-h
| |