Messages in this thread | | | Date | Wed, 24 Sep 2014 11:27:06 -0700 | From | Behan Webster <> | Subject | Re: [PATCH] kbuild, LLVMLinux: Fix asm-offset generation to work with clang |
| |
On 09/24/14 03:37, Arnd Bergmann wrote: > On Tuesday 23 September 2014 12:25:31 behanw@converseincode.com wrote: >> #define DEFINE(sym, val) \ >> - asm volatile("\n->" #sym " %0 " #val : : "i" (val)) >> + asm volatile("\n@->" #sym " %0 " #val : : "i" (val)) > Isn't the '@' character to start a comment architecture specific? I had worried about that as well (as we discussed at LCU), but with the limited testing I tried this with it seemed to indicate that gas was smart enough to handle it in most cases. However the kbuild test robot indicates that this patch breaks MIPS. So indeed your concern is justified.
Gotta love the kbuild test robot. Thank you Fengguang Wu!
> If this makes it work on ARM, what about other architectures? For now, I think I need to try something else.
Thanks,
Behan
-- Behan Webster behanw@converseincode.com
| |