Messages in this thread | | | Date | Wed, 24 Sep 2014 15:55:14 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH V5 10/16] perf, core: simplify need branch stack check |
| |
On Wed, Sep 10, 2014 at 10:09:07AM -0400, kan.liang@intel.com wrote: > From: Kan Liang <kan.liang@intel.com> > > event->attr.branch_sample_type is non-zero no matter branch stack > is enabled explicitly or is enabled implicitly. we can use it to > replace intel_pmu_needs_lbr_smpl(). This avoids duplicating code > that implicitly enables the LBR. >
Please extend the changelog such that it's obvious this is correct. This is the second time I've had to look how this works out for PEBS.
| |