lkml.org 
[lkml]   [2014]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/11] perf/x86/intel: Add Intel Cache QoS Monitoring support
On Wed, Sep 24, 2014 at 09:27:39PM +0100, Matt Fleming wrote:
> > > +static int __init intel_cqm_init(void)
> > > +{
> > > + int i, cpu, ret;
> > > +
> > > + if (!cpu_has(&boot_cpu_data, X86_FEATURE_CQM_OCCUP_LLC))
> > > + return -ENODEV;
> >
> > This should use cpufeature.h
>
> What? Please be more explicit.

Using x86_match_cpu and friends, then it would work for module
auto loading too.

> > But in fact what good is the test then if you only
> > every likely check cpu #0?
>
> We don't, we check every online cpu, not just cpu 0.

There are no other cpus online at this point?

-Andi


\
 
 \ /
  Last update: 2014-09-24 23:21    [W:0.218 / U:0.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site