lkml.org 
[lkml]   [2014]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v1 12/12] tpm: TPM2 sysfs attributes
    Date
    Am Mittwoch, 24. September 2014, 22:19:38 schrieb Jason Gunthorpe:
    > On Wed, Sep 24, 2014 at 10:02:34PM +0300, Jarkko Sakkinen wrote:
    > > > The pcrs file never conformed to the sysfs rules, if TPM2 is getting a
    > > > whole new file set, I wouldn't mind seeing it not include the
    > > > non-conformant ones. What do you think?
    > >
    > > I think that it's better to put extra focus on these sysfs attributes in
    > > first patch set because it's user space visible. What's wrong in the
    > > current pcrs file?
    >
    > Each PCR should be a distinct sysfs file, probably with a
    > directory. One Value Per File is the rule.

    That would be 24*2 files only for pcrs...
    Documentation/filesystems/sysfs.txt says:

    "
    Attributes should be ASCII text files, preferably with only one value
    per file. It is noted that it may not be efficient to contain only one
    value per file, so it is socially acceptable to express an array of
    values of the same type. "

    So it would be more or less o.k. to have it in one file like we had.


    Then however:
    "Mixing types, expressing multiple lines of data, and doing fancy
    formatting of data is heavily frowned upon. Doing these things may get
    you publicly humiliated and your code rewritten without notice."


    Do we really need the PCRs as sysfs files?
    I know they are handy as a dev, but does any application actually use this
    directly?


    Thanks,
    Peter





    \
     
     \ /
      Last update: 2014-09-24 23:01    [W:3.558 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site