lkml.org 
[lkml]   [2014]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [tpmdd-devel] [PATCH v9] tpm_tis: verify interrupt during init
    On 09/23/2014 07:55 AM, Scot Doyle wrote:
    > On Tue, 23 Sep 2014, Scot Doyle wrote:
    > ---
    > drivers/char/tpm/tpm_tis.c | 76 +++++++++++++++++++++++++++++++++++++---------
    > 1 file changed, 62 insertions(+), 14 deletions(-)
    >
    > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
    > index 2c46734..bfe1f1a 100644
    > --- a/drivers/char/tpm/tpm_tis.c
    > +++ b/drivers/char/tpm/tpm_tis.c
    > @@ -75,6 +75,10 @@ enum tis_defaults {
    > #define TPM_DID_VID(l) (0x0F00 | ((l) << 12))
    > #define TPM_RID(l) (0x0F04 | ((l) << 12))
    >
    > +struct priv_data {
    > + bool irq_tested;
    > +};
    > +
    > static LIST_HEAD(tis_chips);
    > static DEFINE_MUTEX(tis_lock);
    >
    > @@ -338,12 +342,27 @@ out_err:
    > return rc;
    > }
    >
    > +static void disable_interrupts(struct tpm_chip *chip)
    > +{
    > + u32 intmask;
    > + intmask =
    > + ioread32(chip->vendor.iobase +
    > + TPM_INT_ENABLE(chip->vendor.locality));
    > + intmask |= TPM_INTF_CMD_READY_INT | TPM_INTF_LOCALITY_CHANGE_INT |
    > + TPM_INTF_DATA_AVAIL_INT | TPM_INTF_STS_VALID_INT;

    You want to disable interrupts but you set all the flags? Maybe you meant:

    intmask &= ~(FOO|BAR)

    ?

    Stefan



    \
     
     \ /
      Last update: 2014-09-23 19:41    [W:3.968 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site