lkml.org 
[lkml]   [2014]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ath: change logging functions to return void
On Tue, Sep 23, 2014 at 07:20:53AM +0300, Kalle Valo wrote:
> Joe Perches <joe@perches.com> writes:
>
> > The return values are not used by callers of these functions
> > so change the functions to return void.
> >
> > Other miscellanea:
> >
> > o add __printf verification to wil6210 logging functions
> > No format/argument mismatches found
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> > This change is associated to a desire to eventually
> > change printk to return void.
> >
> > drivers/net/wireless/ath/ath10k/debug.c | 18 +++++-------------
> > drivers/net/wireless/ath/ath10k/debug.h | 6 +++---
> > drivers/net/wireless/ath/ath6kl/common.h | 2 +-
> > drivers/net/wireless/ath/ath6kl/debug.c | 28 ++++++++--------------------
> > drivers/net/wireless/ath/ath6kl/debug.h | 13 ++++++-------
>
> For ath6kl and ath10k:
>
> Acked-by: Kalle Valo <kvalo@qca.qualcomm.com>
>
> > drivers/net/wireless/ath/wil6210/debug.c | 14 ++++----------
> > drivers/net/wireless/ath/wil6210/wil6210.h | 7 +++++--
> > 7 files changed, 32 insertions(+), 56 deletions(-)
>
> John, as this patch also contains a wil6210 change how do you want to
> handle this?

I had presumed that you would merge it through the ath tree, so I
deleted it...

John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.


\
 
 \ /
  Last update: 2014-09-23 17:41    [W:0.099 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site