Messages in this thread | | | Date | Tue, 23 Sep 2014 18:40:51 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH v2 2/2] watchdog: dw_wdt: add restart handler support |
| |
On 09/23/2014 06:11 PM, Jisheng Zhang wrote: [ ... ] >>> + dw_wdt.restart_handler.notifier_call = dw_wdt_restart_handle; >>> + dw_wdt.restart_handler.priority = 128; >>> + ret = register_restart_handler(&dw_wdt.restart_handler); >>> + if (ret) >>> + pr_warn("cannot register restart handler\n"); >> >> Please use dev_warn(&pdev->dev, ...). > > Yep, that's what I thought when patching the code. But the original source is > using pr_*(), so I use pr_warn() to keep unification. Is there any better > solution? >
Good point. Makes sense, then, to leave that as cleanup.
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
| |