Messages in this thread | | | Date | Tue, 23 Sep 2014 17:51:37 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH linux-next] Documentation: mic: mpssd: Disable mpssd builds for kernels < 3.13 |
| |
On Tue, 23 Sep 2014 19:47:11 -0400 Peter Foley <pefoley2@pefoley.com> wrote:
> On Tue, Sep 23, 2014 at 7:38 PM, Andrew Morton > <akpm@linux-foundation.org> wrote: > > This build error is caused by compiling mpssd prior to `make > > headers_install'. > > > > There's really no reason to check the kernel version. If someone > > transplants mpssd out of its distributed kernel and into some older > > kernel then a miscompile is their problem - their backport is > > incomplete. > > I've only noticed this error when running make Documentation/, > in which case gcc silently uses the headers from the system, > since the headers_install ones don't exist yet. > > Maybe having the build error out in this case instead of having mysterious > compile errors would be a better solution? >
Can't we just fix the Makefiles? Cook up a rule which makes headers_install (if needed) before building Documentation/?
| |