lkml.org 
[lkml]   [2014]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v8] tpm_tis: verify interrupt during init
On Mon, 22 Sep 2014, Jason Gunthorpe wrote:

> On Thu, Sep 11, 2014 at 12:50:00AM +0000, Scot Doyle wrote:
>> + if (!priv->irq_tested) {
>
> I think the sleep and check is still needed here, the IRQ delivery
> could race relative to the MMIO read of completion, a sleep is the
> only way we could attempt to synchronize them..
>
>> + disable_interrupts(chip);
>> + dev_err(chip->dev,
>> + FW_BUG "TPM interrupt not working, polling instead\n");
>> + }
>> + priv->irq_tested = true;
>> + return rc;
>> +}

We re-tested this v9 patch. It has the msleep(1) added just above this
section for better formatting, as well as a devm_kzalloc check in
tpm_tis_init. Thanks!


\
 
 \ /
  Last update: 2014-09-23 05:01    [W:0.137 / U:0.188 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site