Messages in this thread Patch in this message | | | From | Zefan Li <> | Subject | [PATCH 3.4 12/45] CIFS: Fix wrong directory attributes after rename | Date | Tue, 23 Sep 2014 10:31:14 +0800 |
| |
From: Pavel Shilovsky <pshilovsky@samba.org>
3.4.104-rc1 review patch. If anyone has any objections, please let me know.
------------------
commit b46799a8f28c43c5264ac8d8ffa28b311b557e03 upstream.
When we requests rename we also need to update attributes of both source and target parent directories. Not doing it causes generic/309 xfstest to fail on SMB2 mounts. Fix this by marking these directories for force revalidating.
Signed-off-by: Pavel Shilovsky <pshilovsky@samba.org> Signed-off-by: Steve French <smfrench@gmail.com> Signed-off-by: Zefan Li <lizefan@huawei.com> --- fs/cifs/inode.c | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c index 43944c6..8d6ac6b 100644 --- a/fs/cifs/inode.c +++ b/fs/cifs/inode.c @@ -1653,6 +1653,12 @@ unlink_target: target_dentry, toName); } + /* force revalidate to go get info when needed */ + CIFS_I(source_dir)->time = CIFS_I(target_dir)->time = 0; + + source_dir->i_ctime = source_dir->i_mtime = target_dir->i_ctime = + target_dir->i_mtime = current_fs_time(source_dir->i_sb); + cifs_rename_exit: kfree(info_buf_source); kfree(fromName); -- 1.7.9.5
| |