Messages in this thread | | | Date | Mon, 22 Sep 2014 14:54:45 -0700 | Subject | Re: [PATCH v3] kvm: Fix page ageing bugs | From | Andres Lagar-Cavilla <> |
| |
On Mon, Sep 22, 2014 at 2:48 PM, Paolo Bonzini <pbonzini@redhat.com> wrote: > Il 22/09/2014 22:26, Andres Lagar-Cavilla ha scritto: >> + __entry->gfn = gfn; >> + __entry->hva = ((gfn - slot->base_gfn) >> > > This must be <<.
Correct, thanks.
> >> + PAGE_SHIFT) + slot->userspace_addr; > >> + /* >> + * No need for _notify because we're called within an >> + * mmu_notifier_invalidate_range_ {start|end} scope. >> + */ > > Why "called within"? It is try_to_unmap_cluster itself that calls > mmu_notifier_invalidate_range_*, so "we're within an > mmu_notifier_invalidate_range_start/end scope" sounds better, and it's > also what you use in the commit message.
Also correct. V4... Andres
> > Paolo
-- Andres Lagar-Cavilla | Google Kernel Team | andreslc@google.com
| |