Messages in this thread | | | From | Pranith Kumar <> | Date | Mon, 22 Sep 2014 16:20:08 -0400 | Subject | Re: [RFC PATCH] x86: Use ACCESS_ONCE() for atomic_read() |
| |
On Mon, Sep 22, 2014 at 4:07 PM, Peter Zijlstra <peterz@infradead.org> wrote: > On Mon, Sep 22, 2014 at 03:53:09PM -0400, Pranith Kumar wrote: >> Use the much easier to read ACCESS_ONCE() which is basically the same thing as >> the cast to volatile. >> >> Please note the change in volatile cast: ACCESS_ONCE(v)->counter to >> ACCESS_ONCE(v->counter). >> >> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> >> --- >> arch/x86/include/asm/atomic.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > If you want to do something like so, then be consistent and do them all.
Sure, I will change this in all architectures and send in an updated patch.
Thanks! -- Pranith
| |