lkml.org 
[lkml]   [2014]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/7] Silence even more W=2 warnings
On Mon, Sep 22, 2014 at 05:06:27PM +0000, Rustad, Mark D wrote:
> The problem is that the kernel include files throw so many warnings
> that it really discourages anyone from ever going through them, even
> for a single driver. The warnings are far more valuable and usable
> when known acceptable usages are silenced.

You can always do one file only, for example:

make W=2 arch/x86/kernel/msr.o > w.log 2>&1

> Well, the whole series of patches that I made definitely went too far
> - only the first 5 out of about 30 have been posted, but if we can
> make some progress on generating fewer warnings out of the include
> files, I think it would be helpful.

Helpful for what? Those are W=2 warnings which are disabled in the
default build.

> Already the patches that use them have triggered some activity that
> has resulted in resolving warnings without use of the macros, and I
> see that as much better than simply using the macros.
>
> The macros can serve a useful purpose, but they should not be widely
> used. When to use them is definitely a judgement call. If the macros
> are accepted, it may be worth adding a checkpatch.pl warning for
> adding a DIAG_*IGNORE macro.

Right, so add the macros and tell people *not* to use them. That won't
fly.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--


\
 
 \ /
  Last update: 2014-09-22 21:21    [W:0.082 / U:1.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site