Messages in this thread | | | Date | Mon, 22 Sep 2014 11:35:36 -0700 | From | Brian Norris <> | Subject | Re: [PATCH v3 1/2] mtd: nand: support ONFI timing mode retrieval for non-ONFI NANDs |
| |
> diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h > index b7c1199..b0b74cc 100644 > --- a/include/linux/mtd/nand.h > +++ b/include/linux/mtd/nand.h > @@ -587,6 +587,11 @@ struct nand_buffers { > * @ecc_step_ds: [INTERN] ECC step required by the @ecc_strength_ds, > * also from the datasheet. It is the recommended ECC step > * size, if known; if unknown, set to zero. > + * @onfi_timing_mode_default: [INTERN] default ONFI timing mode. This field is > + * either deduced from the datasheet if the NAND > + * chip is not ONFI compliant or set to 0 if it is > + * (an ONFI chip is always configured in mode 0 > + * after a NAND reset)
This is probably OK only if every NAND chip is at least as fast as ONFI mode 0. For older / legacy flash, I'm not sure if that's 100% true. Maybe we'll need an UNKNOWN value, for those whose timing information is not known?
Anyway, I think this is OK for now. Pushed the series to l2-mtd.git. Thanks!
> * @numchips: [INTERN] number of physical chips > * @chipsize: [INTERN] the size of one chip for multichip arrays > * @pagemask: [INTERN] page number mask = number of (pages / chip) - 1
Brian
| |