lkml.org 
[lkml]   [2014]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] sched: fix the task-group check in tg_has_rt_tasks()
From
Date
В Вс, 21/09/2014 в 21:33 +0200, Oleg Nesterov пишет:
> tg_has_rt_tasks() wants to find an RT task in this task_group, but
> task_rq(p)->rt.tg wrongly checks the root rt_rq.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Reviewed-by: Kirill Tkhai <ktkhai@parallels.com>

> ---
> kernel/sched/core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index eee12b3..9023f56 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -7354,7 +7354,7 @@ static inline int tg_has_rt_tasks(struct task_group *tg)
> struct task_struct *g, *p;
>
> for_each_process_thread(g, p) {
> - if (rt_task(p) && task_rq(p)->rt.tg == tg)
> + if (rt_task(p) && task_group(p) == tg)
> return 1;
> }
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2014-09-22 09:21    [W:0.050 / U:2.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site