lkml.org 
[lkml]   [2014]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Xen-devel] [PATCH 3/3 v2] xen/xenbus: Improve failure processing code for __xenbus_switch_state()
On 18/09/14 15:01, Chen Gang wrote:
> When failure occurs, need return failure code instead of 0, or some of
> indirect upper callers may misunderstand.
>
> e.g. in "block/xen-blkback/xenbus.c":
>
> connect() -> xenbus_switch_state() -> __xenbus_switch_state().

Can you make xenbus_switch_state() void? The callers don't need to do
any error handling.

David


\
 
 \ /
  Last update: 2014-09-22 17:41    [W:1.186 / U:1.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site