Messages in this thread | | | Date | Mon, 22 Sep 2014 16:04:19 +0100 | From | David Vrabel <> | Subject | Re: [Xen-devel] [PATCH 3/3 v2] xen/xenbus: Improve failure processing code for __xenbus_switch_state() |
| |
On 18/09/14 15:01, Chen Gang wrote: > When failure occurs, need return failure code instead of 0, or some of > indirect upper callers may misunderstand. > > e.g. in "block/xen-blkback/xenbus.c": > > connect() -> xenbus_switch_state() -> __xenbus_switch_state().
Can you make xenbus_switch_state() void? The callers don't need to do any error handling.
David
| |