Messages in this thread | | | Date | Mon, 22 Sep 2014 11:51:09 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH 4/5] perf tools: Introduce perf_callchain_config() |
| |
Em Mon, Sep 22, 2014 at 04:25:10PM +0200, Jiri Olsa escreveu: > On Sun, Sep 21, 2014 at 01:18:05AM +0900, Namhyung Kim wrote: > > +int perf_callchain_config(const char *var, const char *value) > > +{ > > + if (prefixcmp(var, "call-graph.")) > > + return 0; > > + var += 11; /* strlen("call-graph.") == 11 */
> should we use sizeof("call-graph.") - 1 instead ?
Agreed, it should produce the same code and is more compact :-)
- Arnaldo
| |