Messages in this thread | | | Date | Mon, 22 Sep 2014 12:47:30 +0800 | From | Chris Zhong <> | Subject | Re: [PATCH v4 1/2] regulator: st-pwm: get voltage and duty table from dts |
| |
On 09/22/2014 12:18 PM, Doug Anderson wrote: > Chris, > > On Sun, Sep 21, 2014 at 7:52 PM, Chris Zhong <zyw@rock-chips.com> wrote: >> Get voltage & duty table from device tree might be better, other platforms can also use this >> driver without any modify. >> >> Signed-off-by: Chris Zhong <zyw@rock-chips.com> >> >> Reviewed-by: Doug Anderson <dianders@chromium.org> > No need to re-spin, but please remember that all tags should be > bunched together (no blank lines). In other words, > > YES: > >> Signed-off-by: Chris Zhong <zyw@rock-chips.com> >> Reviewed-by: Doug Anderson <dianders@chromium.org> > NO: > >> Signed-off-by: Chris Zhong <zyw@rock-chips.com> >> >> Reviewed-by: Doug Anderson <dianders@chromium.org> Thanks. It seems the patman add the blank line, I will manually modify it next time.
| |